Skip to content

Conversation

@AltamashShaikh
Copy link
Contributor

Description

Removed Piwik reference

Issue No

#PG-4266

Steps to Replicate the Issue

Simple textual change from the list provided.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?

@AltamashShaikh AltamashShaikh requested a review from a team June 25, 2025 11:12
snake14
snake14 previously approved these changes Jun 25, 2025
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's more that could be changed, but it looks like you're going off of a specific list 👍

The main question I had was whether the keywords in plugin.json should be adjusted too.

@james-hill-matomo
Copy link

I wrote the list, and (so long as Stan agrees) I'm happy to deviate from it.

For the keywords, my assumption is that we should keep piwik there, but we should also add matomo. Technically out of scope, but it makes sense to me.

@james-hill-matomo
Copy link

I wrote the list, and (so long as Stan agrees) I'm happy to deviate from it.

For the keywords, my assumption is that we should keep piwik there, but we should also add matomo. Technically out of scope, but it makes sense to me.

I see @AltamashShaikh already asked Stan in Jira about this :)

@AltamashShaikh
Copy link
Contributor Author

@snake14 @james-hill-matomo Added Matomo as a keyword, guess there is no harm in adding it.

@AltamashShaikh AltamashShaikh requested a review from snake14 June 26, 2025 11:36
@snake14 snake14 merged commit cacd92e into 5.x-dev Jun 26, 2025
8 checks passed
@snake14 snake14 deleted the PG-4266-remove-piwik-ref branch June 26, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants